feature: Send Chat Bubble to all players #2455 #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeylonSantana
previously approved these changes
Jan 8, 2025
TimtyG
changed the title
AlexVild
previously approved these changes
Jan 8, 2025
WeylonSantana
requested changes
Jan 8, 2025
Contributor
WeylonSantana
left a comment
WeylonSantana
left a comment
There was a problem hiding this comment.
just remove the comments the code is self explanatory, other than that I approve too
Framework/Intersect.Framework.Core/GameObjects/Events/Commands/EventCommands.cs
Outdated
Show resolved
Hide resolved
WeylonSantana
previously approved these changes
Jan 8, 2025
pandinocoder
requested changes
Jan 9, 2025
Member
pandinocoder
left a comment
pandinocoder
left a comment
There was a problem hiding this comment.
Can we have a screenshot of the option in the editor?
Intersect.Editor/Forms/Editors/Events/Event Commands/EventCommand_ChatboxText.resx
Outdated
Show resolved
Hide resolved
Framework/Intersect.Framework.Core/GameObjects/Events/Commands/EventCommands.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
20250108-2047-00.9835143.mp4 |
pandinocoder
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2455
I have added a "Send to All Players" checkbox in the editor form, allowing the user to choose whether the chat bubble should be visible to the triggering player only, or broadcast to all players in the same area.